Fix ContextTest comparison of ContextActivities signatures. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grouping array was sent as argument 2 to the $contextActivities2 constructor. ContextActivities->__construct() only takes one argument and will not assign ANY properties if there is not exactly one argument. This cause $contextActivities2 to have a different number of parents than $contextActivities1. I believe the intent of 'contextActivities only: mismatch' and 'full: contextActivities mismatch' cases is to detect differences in the number of contextActivities->grouping objects.
This allows the tests to be run with PHPUnit 4.8.*, 5.4.* and 6.*.
'@stable' causes testing of PHP 7.0 to use PHPUnit 6.4, which breaks compatibility with PHPUnit 4.8 and 5.7.
If the HTTP header context option is an array of headers, HHVM sends an 'Array to string conversion' notice.
|
#96 should be merged first in order to pass PHP 7 and HHVM tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grouping array was sent as argument 2 to the $contextActivities2 constructor. ContextActivities->__construct() only takes one argument and will not assign ANY properties if there is not exactly one argument. This cause $contextActivities2 to have a different number of parents than $contextActivities1. I believe the intent of 'contextActivities only: mismatch' and 'full: contextActivities mismatch' cases is to detect differences in the number of contextActivities->grouping objects.