Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings page #51

Merged
merged 88 commits into from
Feb 21, 2025
Merged

Add settings page #51

merged 88 commits into from
Feb 21, 2025

Conversation

RyanLua
Copy link
Owner

@RyanLua RyanLua commented Feb 3, 2025

Description

Adds a new settings button to the right of the start button.

Contains the following settings:

  • App theme
  • Backdrop material
  • Always on top
  • Notification badge
  • App info

Numerous general improvements have been added as well.

image
image

Related Issues

Closes #31
Closes #42

Changes Made

This pull request includes various updates to the FluentAutoClicker project, focusing on refactoring, new feature additions, and improvements to existing functionalities. The most important changes include the introduction of a new IsEnabledTextBlock control, updates to the MainPage.xaml layout, and modifications to the App.xaml and App.xaml.cs files.

Refactoring and Code Improvements:

New Features:

Layout and UI Enhancements:

Dependency Updates:

Miscellaneous:

Checklist

  • Move strings from hard-coded to resource files
  • Add settings saving or move it to an issue
  • Fix checkbox binding breaking after pausing clicking
  • Update legacy code to use bindings
  • I have tested these changes thoroughly.
  • I have reviewed my code for any potential errors or issues.
  • I have followed the code style guidelines for this project.

Additional Notes

@RyanLua RyanLua linked an issue Feb 14, 2025 that may be closed by this pull request
1 task
@RyanLua RyanLua changed the title Add early settings page implementation Add settings page Feb 21, 2025
@RyanLua RyanLua marked this pull request as ready for review February 21, 2025 03:35
@RyanLua RyanLua requested a review from Copilot February 21, 2025 03:35
@RyanLua RyanLua added the dependencies Pull requests that update a dependency file label Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.

Files not reviewed (12)
  • FluentAutoClicker/App.xaml: Language not supported
  • FluentAutoClicker/Controls/IsEnabledTextBlock/IsEnabledTextBlock.xaml: Language not supported
  • FluentAutoClicker/FluentAutoClicker.csproj: Language not supported
  • FluentAutoClicker/MainPage.xaml: Language not supported
  • FluentAutoClicker/MainWindow.xaml: Language not supported
  • FluentAutoClicker/Package.appxmanifest: Language not supported
  • FluentAutoClicker/SettingsPage.xaml: Language not supported
  • FluentAutoClicker/Strings/en-us/Resources.resw: Language not supported
  • FluentAutoClicker/Styles.xaml: Language not supported
  • FluentAutoClicker/Themes/Generic.xaml: Language not supported
  • FluentAutoClicker/Program.cs: Evaluated as low risk
  • FluentAutoClicker/App.xaml.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)

FluentAutoClicker/MainPage.xaml.cs:50

  • The 'SetNotificationBadge' method should be tested to ensure it correctly sets the badge notification based on the settings.
SetNotificationBadge(BadgeNotificationGlyph.Paused);

FluentAutoClicker/MainPage.xaml.cs:102

  • The 'SetNotificationBadge' method could potentially cause issues if the 'SettingsPage' instance isn't properly initialized. This should be covered by tests.
SettingsPage settingsPage = new();

FluentAutoClicker/Helpers/AutoClicker.cs:8

  • Creating a new Random instance inside the loop can lead to less randomness. Move the Random instance outside the loop.
int randomClickOffset = new Random().Next(0, clickOffset);
@RyanLua RyanLua merged commit 829259d into main Feb 21, 2025
7 checks passed
@RyanLua RyanLua deleted the settings-page branch February 21, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text does not update to correct app theme Crashes after another program registers the same hotkey
1 participant