Implement REST command #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason it is still in draft? Will merge, looks good and didnt appear to break anything. Thank you! |
|
It wasn't marked draft for any particular good reason, I was just curious if you wanted it cleaned up any further, but it's at least as good as the rest of the stuff that's there so the merge is fine by me :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the restart command which allows for resuming interrupted file reads, or in my case, abusing the protocol for efficient file seeking and partial reading. It also fixes a bug in
ftp_cmd_retrwhere a file would continue to be read/transferred after aborting the connection client-side.