Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new helper type for SAFE.Client: Optimistic #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a new helper type for SAFE.Client: Optimistic #12

wants to merge 2 commits into from

Conversation

arpxspace
Copy link

@arpxspace arpxspace commented Jan 24, 2025 •
edited
Loading

supports frontend development.

what changed?: add new helper client types for optimistic update
why?: aid in front end development

implements #11

@arpxspace
[feat]: Add new helper client types for optimistic update to support …
aeb607c 
…frontend development.

what changed?: add new helper client types for optimistic update
why?: aid in front end development
effect?: n/a
@arpxspace
[feat]: Updated XML docs; changed Curr property to Value for clarity.
b4fd825 
what changed?: more xml docs and change Curr property to Value for more familiar usage
why?: doing x.Curr makes less sense than doing x.Value
effect?: n/a
@Larocceau
Copy link
Contributor

Interesting addition, curious to see it in action!

A few pieces of feedback:

  • Can you add unit tests? I know the behaviour is trivial, but it's still nice to have unit tests so we can refactor more freely
  • Can you add a module that has functions corresponding to the member functions on the type?
  • I think it would be good to have some more basic functions for working with monads implemented, like map and bind, and perhaps we should add an asOption function as well. Look at the remoteData for more inspiration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgallagher92 mattgallagher92 Awaiting requested review from mattgallagher92

@isaacabraham isaacabraham Awaiting requested review from isaacabraham

@Larocceau Larocceau Awaiting requested review from Larocceau

@jwthomson jwthomson Awaiting requested review from jwthomson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpxspace @Larocceau