Skip to content

Commit

Permalink
Sample: on-premise-docker-registry
Browse files Browse the repository at this point in the history
- Fix minor issue in Makefile target
- Update README.md
  • Loading branch information
abbi-gaurav committed Sep 12, 2023
1 parent 73b399d commit f5dfef2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion on-premise-docker-registry/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ create-test-image:
docker push ${IMAGE_NAME}

create-secret-to-pull-image:
kubectl create secret docker-registry on-premise-reg \
kubectl -n ${NAMESPACE} create secret docker-registry on-premise-reg \
--docker-username=${REG_USER_NAME} \
--docker-password=${REG_USER_PASSWD} \
--docker-email=${EMAIL} \
Expand Down
4 changes: 2 additions & 2 deletions on-premise-docker-registry/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Export the following environment variables:
```shell
export KUBECONFIG=<path-to-kubeconfig>
export NAMESPACE={kyma-namespace-used-for-this-sample}
export CLUSTER_DOMAIN={kyma-cluster-domain}
export CLUSTER_DOMAIN=$(kubectl get cm -n kube-system shoot-info -ojsonpath='{.data.domain}')
export REG_USER_NAME={docker-registry-user}
export REG_USER_PASSWD={docker-registry-password}
export EMAIL={your-email}
Expand Down Expand Up @@ -100,7 +100,7 @@ When creating a Deployment, specify the Docker registry as `localhost:{NodePort}

This sample shows a simple configuration with Nginx as a reverse proxy. You can use any other reverse proxy implementation based on your on-premise Docker registry behavior and APIs.

1. Create a Namespace and make sure Istio sidecar injection is enabled.
1. Create a Namespace if not already created and make sure Istio sidecar injection is enabled.

```shell
kubectl create namespace ${NAMESPACE}
Expand Down

0 comments on commit f5dfef2

Please sign in to comment.