-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no escaping for standard escapes in regular expressions #315
Conversation
@wurzka @Markus1812 The failing test runs successfully when I run it locally with ABAP Unit. Do you have any ideas why it might fail in the gh action? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some detailed discussions with @Markus1812. Our result is:
- Replace \ with \\
- Replace " with \"
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
add a skip to https://github.com/SAP/abap-file-formats-tools/blob/fix-regex-escape-sequences/test/abap_transpile.json#L55 to make the unit tests succeed, I spend some time yesterday to try fixing the regex, but too much escaping of stuff |
Thank you! @larshp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Maybe you could also include the escaping behavior of "
in your new test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks also good to me. But I agree with @Markus1812 about adding the test.
I added the test and also verified that it works with a single quote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Achievement unlocked: @jonassobotta is now an escape master 😀
fixes #314