improve default mocking for 404

SAP · Dec 21, 2023 · 13417e9 · 13417e9
1 parent d8a140a
commit 13417e9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/...ages/connectivity/src/scp-cf/destination/destination-accessor-authentication-type.spec.ts b/...ages/connectivity/src/scp-cf/destination/destination-accessor-authentication-type.spec.ts
@@ -191,8 +191,7 @@ describe('authentication types', () => {
           mockAuthCall: { headers: { 'x-tenant': testTenants.subscriber } }
         }),
         ...mockFindDestinationCallsNotFound(destinationName, {
-          serviceToken: subscriberServiceToken,
-          mockAuthCall: false
+          serviceToken: subscriberServiceToken
         })
       ];
 
@@ -216,8 +215,7 @@ describe('authentication types', () => {
           mockAuthCall: { headers: { 'x-user-token': subscriberUserToken } }
         }),
         ...mockFindDestinationCallsNotFound(destinationName, {
-          serviceToken: subscriberServiceToken,
-          mockAuthCall: false
+          serviceToken: subscriberServiceToken
         })
       ];
 

diff --git a/packages/connectivity/src/scp-cf/destination/destination-accessor-failure-cases.spec.ts b/packages/connectivity/src/scp-cf/destination/destination-accessor-failure-cases.spec.ts
@@ -140,12 +140,9 @@ describe('Failure cases', () => {
     mockServiceToken();
 
     const httpMocks = [
+      ...mockFindDestinationCallsNotFound(destinationName),
       ...mockFindDestinationCallsNotFound(destinationName, {
-        mockAuthCall: false
-      }),
-      ...mockFindDestinationCallsNotFound(destinationName, {
-        serviceToken: subscriberServiceToken,
-        mockAuthCall: false
+        serviceToken: subscriberServiceToken
       })
     ];
 

diff --git a/packages/connectivity/src/scp-cf/destination/destination-cache.spec.ts b/packages/connectivity/src/scp-cf/destination/destination-cache.spec.ts
@@ -655,8 +655,7 @@ describe('destination cache', () => {
       );
 
       const [httpMock] = mockFindDestinationCallsNotFound('ProviderDest', {
-        serviceToken: subscriberServiceToken,
-        mockAuthCall: false
+        serviceToken: subscriberServiceToken
       });
 
       const actual = await getDestination({

diff --git a/test-resources/test/test-util/destination-service-mocks.ts b/test-resources/test/test-util/destination-service-mocks.ts
@@ -177,6 +177,7 @@ export function mockFindDestinationCallsNotFound(
       ErrorMessage: 'Configuration with the specified name was not found'
     },
     responseCode: 404,
+    mockAuthCall: false,
     ...options
   });
 }