-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to eslint 9 and the flat configuration #12877
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
f1849ae
to
830987e
Compare
Visit the preview URL for this PR (updated for commit a577425): https://fundamental-ngx-gh--pr12877-eslint-9-n0f3yx2r.web.app (expires Thu, 06 Feb 2025 19:23:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertIsaac this appears to introduce some problems with committing. For example, i just opened this file and entered a tab before a variable definition, to test the formatting. On commit, I see the error: 42:5 error Definition for rule '@angular-eslint/no-output-on-prefix' was not found @angular-eslint/no-output-on-prefix
@mikerodonnell89 to illustrate the problem try these command eslint libs\platform\form\auto-complete\auto-complete.directive.ts # will fail
cd .\libs\platform\
eslint form\auto-complete\auto-complete.directive.ts # will pass the problem is that lint-staged is triggering eslint directly which will be using the root-level eslint.config.js file not the while now how to fix this problem? to be honest I'm not sure |
I used the flag |
Description
currently the repo is using the old
.eslintrc
and the unsupport eslint 8 versionsthis PR migrate to the new flat configuration and eslint 9
I also updated nx since the old version was buggy, you may want to do the upgrade in a separate branch first which is understandable
note that I didn't add all the old plugins, this can be done in a future PR, or if mandatory I can work on it in the future