Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svelte example #3541

Merged
merged 17 commits into from
Dec 7, 2023
Merged

Update svelte example #3541

merged 17 commits into from
Dec 7, 2023

Conversation

ndricimrr
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Packages updated but still need to migrate to major svelte version.

Related issue(s)

Fixes #3501

@ndricimrr ndricimrr added the internal Stuff like NFRs, CI pipeline label Nov 24, 2023
@camelCaseChris
Copy link
Contributor

Looks good to me. I tried the updated example locally, it worked fine.

Just one glitch - not sure if you care about it. When running the dev script for the very first time, serve:luigi and serve:microfrontend exit with this:

[1] npm run serve:luigi exited with code 1
[2] The system cannot find the path specified.
[2] npm run serve:microfrontend exited with code 1

When running dev a second time, everything works.

From what I could see, the problem is that serve:luigi and serve:microfrontend start before build:dev is finished and they cannot handle the public folder not being there yet. You can simulate this by deleting the public folder and then running dev again.

@ndricimrr
Copy link
Contributor Author

@camelCaseChris Good point. Adjusted as necessary.

Copy link
Contributor

@camelCaseChris camelCaseChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ndricimrr ndricimrr merged commit a07e12e into main Dec 7, 2023
11 checks passed
@ndricimrr ndricimrr deleted the 3501-svelte-example-fix branch December 7, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Stuff like NFRs, CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte example does not work
2 participants