Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds theme property for compound container #3936

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Adds theme property for compound container #3936

merged 4 commits into from
Sep 24, 2024

Conversation

walmazacn
Copy link
Contributor

Description

Changes proposed in this pull request:

  • adds theme property for compound container
  • adds related e2e test

Related issue(s)

Resolves #3927

@walmazacn walmazacn linked an issue Sep 20, 2024 that may be closed by this pull request
theme property missing for LuigiCompoundContainer #3927
Closed
@ndricimrr ndricimrr self-assigned this Sep 23, 2024
ndricimrr
ndricimrr approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@walmazacn walmazacn merged commit cbef792 into main Sep 24, 2024
12 checks passed
@walmazacn walmazacn deleted the 3927-theme-property-in-luigicompoundcontainer branch September 24, 2024 08:50
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Nov 5, 2024
@JohannesDoberer JohannesDoberer mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@ndricimrr ndricimrr

Labels
container enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

theme property missing for LuigiCompoundContainer
3 participants
@walmazacn @ndricimrr @JohannesDoberer