Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cf-gen): adds new sub generator to @sap-ux/cf-deploy-config-sub-generator #2844

Merged
merged 20 commits into from
Feb 5, 2025

Conversation

cianmSAP
Copy link
Contributor

#2843

Adds Cloud foundry deployment configuration generator to @sap-ux/cf-deploy-config-sub-generator

Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 5cc7e8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sap-ux/cf-deploy-config-sub-generator Minor
@sap-ux/cf-deploy-config-inquirer Minor
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP requested review from kjose90 and longieirl January 31, 2025 17:03
Copy link
Member

@kjose90 kjose90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP - PR looks very good and clean.
Changes are clear. Tests and changeset ✅
just few minor comments ...

packages/cf-deploy-config-sub-generator/src/app/index.ts Outdated Show resolved Hide resolved
packages/cf-deploy-config-sub-generator/src/app/index.ts Outdated Show resolved Hide resolved
packages/cf-deploy-config-sub-generator/src/app/index.ts Outdated Show resolved Hide resolved
kjose90
kjose90 previously approved these changes Feb 4, 2025
Copy link
Member

@kjose90 kjose90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.
Changes, tests and change set are clear ✅

longieirl
longieirl previously approved these changes Feb 4, 2025
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Havent tested locally.
Changesets are good.
Will validate once consumed into tools-suite.

@cianmSAP cianmSAP dismissed stale reviews from longieirl and kjose90 via f855bd6 February 4, 2025 15:59
Copy link
Member

@kjose90 kjose90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re approving

@cianmSAP cianmSAP requested a review from longieirl February 5, 2025 08:55
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re approving

@cianmSAP cianmSAP merged commit 9b755fc into main Feb 5, 2025
16 checks passed
@cianmSAP cianmSAP deleted the feat/cf-gen/2843-cf-sub-gen branch February 5, 2025 09:48
devinea added a commit that referenced this pull request Feb 7, 2025
* origin/main: (43 commits)
  chore: apply latest changesets
  feat(abap-deploy-config-inq): option for createDuringDeploy list item (#2864)
  chore: apply latest changesets
  feat(preview-middleware):add support for type component (#2872)
  chore: apply latest changesets
  feat: introduce ADP FLP config generator (#2730)
  fix(cf-gen): fix unstable windows test (#2876)
  chore: apply latest changesets
  fix: project access dependency (#2875)
  chore: apply latest changesets
  feat(odata-service-inquirer): #2866 - Adds cf bas prompts (#2867)
  chore: apply latest changesets
  feat: add context menu for outline in cpe (#2847)
  chore: apply latest changesets
  feat(cf-gen): adds new sub generator to `@sap-ux/cf-deploy-config-sub-generator` (#2844)
  chore: apply latest changesets
  fix: Default model naming (#2862)
  chore: apply latest changesets
  correct command type for add annotation file (#2839)
  chore: apply latest changesets
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants