Remove _master binary usage (#208)

* remove usage of master binary * resolve merge conflict * lint fix --------- Co-authored-by: Gulom Alimov <[email protected]>
SAP · Aug 15, 2024 · eab2f71 · eab2f71
1 parent 0e89613
commit eab2f71
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 28 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/github.ts b/src/github.ts
@@ -166,7 +166,7 @@ async function getPiperBinaryNameFromInputs (isEnterpriseStep: boolean, version?
     piper = 'sap-piper'
   }
   if (version === 'master') {
-    piper += '_master'
+    info('using _master binaries is deprecated. Using latest release version instead.')
   }
   return piper
 }

diff --git a/test/github.test.ts b/test/github.test.ts
@@ -90,31 +90,6 @@ describe('GitHub package tests', () => {
     expect(core.info).toHaveBeenCalledTimes(1)
   })
 
-  test('downloadPiperBinary - OS step, master', async () => {
-    const assetUrl = `${githubApiURL}/release/assets/123456`
-    jest.spyOn(octokit, 'Octokit').mockImplementationOnce(() => {
-      return {
-        request: async () => {
-          return {
-            data: {
-              tag_name: version,
-              assets: [{ name: 'piper_master', url: assetUrl }]
-            },
-            status: 200
-          }
-        }
-      } as unknown as octokit.Octokit
-    })
-
-    await downloadPiperBinary(osStep, 'master', githubApiURL, token, owner, repo)
-    expect(core.debug).toHaveBeenNthCalledWith(1, 'Fetching binary from GitHub API')
-    expect(core.debug).toHaveBeenNthCalledWith(2, `Fetching release info from ${githubApiURL}/repos/${owner}/${repo}/releases/latest`)
-    expect(core.debug).toHaveBeenNthCalledWith(5, `Found asset URL: ${assetUrl} and tag: ${version}`)
-    expect(core.debug).toHaveBeenCalledTimes(5)
-    expect(core.info).toHaveBeenNthCalledWith(1, expect.stringContaining(`Downloading '${assetUrl}' as '${process.cwd()}/${version.replace(/\./g, '_')}/piper_master'`))
-    expect(core.info).toHaveBeenCalledTimes(1)
-  })
-
   test('downloadPiperBinary - OS step, exact version', async () => {
     const assetUrl = `${githubApiURL}/release/assets/123456`
     jest.spyOn(octokit, 'Octokit').mockImplementationOnce(() => {