DMC: Support Visual Inspection Scenarios #90
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports retrieval of active scenarios and inspection logs from the DMC AIML API. Allows export of InspectionLogSets as DataFrames usable for general ML, binary classification, multilabel classification and object detection based on available information along with dictionaries containing the file content mapped to the file id.
Reduced duplications in inspection logs by implementing functions commonly used by all 'as_ml_input()' methods. Implemented some additional tests for some edge cases that were overlooked initially. Fixed code smells with bounding box conditions, order of and spacing between inputs and refactored all non-compliant docstrings.
cloudyday
reviewed
Nov 18, 2021
Comment on lines
+39
to
+40
| 'from_date': 'fromDate', | ||
| 'to_date': 'toDate', |
There was a problem hiding this comment.
this expects a very clearly defined format (yyyy-MM-dd HH:mm:ss). milliseconds can also be appended after a .. (e.g. 2021-11-18 00:00:00.999) not adhering to this format results in a HTTP 400 with no hint to what went wrong.
we have a problem in general with this "homebrew" list of filter fields and the corresponding "non-odata conform" filter language. we're not able to add query transformers.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cloudyday
reviewed
Nov 24, 2021
cloudyday
reviewed
Nov 24, 2021
Comment on lines
+39
to
+40
| 'from_date': 'fromDate', | ||
| 'to_date': 'toDate', |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
small changes according to review for Scenarios
inspectionLog has a unique ID now. timestamp now maps to inspectionLogTime tests adapted and simplified
inspectionLogTime is now a pd.Timestamp Consolidate data model (no tests) store decoded images in InspectionLogSet with duplicate warning small code and test adaptations fix Inspection Log tests Update comments Rename find_scenarios and update docstring
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports retrieval of active scenarios and inspection logs from the DMC AIML API. Allows export of InspectionLogSets as DataFrames usable for general ML, binary classification, multilabel classification and object detection based on available information along with dictionaries containing the file content mapped to the file id.
Description
Supported the following use case for the DMC API:
a. as_ml_input(),
b. as_binary_classification_input()
c. as_multilabel_classification_input()
d. as_object_detection_input()
Checklist
Mark "not applicable" if item on the list does not apply to this pull request.