-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move from circleci to github actions #504
Closed
+168
−150
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
adac4cc
feat: move from circleci to github actions
uxkjaer 71708ee
feat: changed prerelease to false
uxkjaer db0ec6e
feat: updating node18 unset options
uxkjaer ef2942d
feat: added act documentation to contributing
uxkjaer 489258f
refactor: set openssl-legacy in build for 18
uxkjaer 0dece75
refactor: changed build step names
uxkjaer 270bb73
refactor: deleted circleci
uxkjaer f3ab452
refactor: enable integration tests
uxkjaer ba1ed15
refactor: bad yaml
uxkjaer 5d1bd3b
refactor: bad yaml again
uxkjaer 958d0d1
refactor: end if properly
uxkjaer 38b15cb
refactor: added more proper naming to steps
uxkjaer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: set openssl-legacy in build for 18
commit 489258f94d79549952a1173658753451dc1601db
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,19 +25,28 @@ jobs: | |
cache: 'yarn' | ||
- name: Setup yarn | ||
run: npm install -g yarn | ||
- name: Override NODE options with openssl-legacy-provider for webpack on node v18 | ||
# - name: Override NODE options with openssl-legacy-provider for webpack on node v18 | ||
# if: matrix.node-version == '18.x' | ||
# run: | | ||
# echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV | ||
- name: Build | ||
if: matrix.node-version == '18.x' | ||
run: | | ||
echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV | ||
|
||
yarn | ||
yarn run ci | ||
env: | ||
NODE_OPTIONS: "--openssl-legacy-provider" | ||
- name: Build | ||
if: matrix.node-version != '18.x' | ||
run: | | ||
|
||
yarn | ||
yarn run ci | ||
- name: Remove openssl-legacy-provider from node options on node v18 | ||
if: matrix.node-version == '18.x' | ||
run: | | ||
unset NODE_OPTIONS | ||
# - name: Remove openssl-legacy-provider from node options on node v18 | ||
# if: matrix.node-version == '18.x' | ||
# run: | | ||
# unset NODE_OPTIONS | ||
compliance: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does not this mean the |
||
runs-on: ubuntu-latest | ||
env: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik
setup-node
action supports yarn so no need for a separate yarn install step