Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move from circleci to github actions #504

Closed
wants to merge 12 commits into from
Prev Previous commit
Next Next commit
refactor: set openssl-legacy in build for 18
uxkjaer committed Oct 18, 2022
commit 489258f94d79549952a1173658753451dc1601db
21 changes: 15 additions & 6 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
@@ -25,19 +25,28 @@ jobs:
cache: 'yarn'
- name: Setup yarn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik setup-node action supports yarn so no need for a separate yarn install step

run: npm install -g yarn
- name: Override NODE options with openssl-legacy-provider for webpack on node v18
# - name: Override NODE options with openssl-legacy-provider for webpack on node v18
# if: matrix.node-version == '18.x'
# run: |
# echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV
- name: Build
if: matrix.node-version == '18.x'
run: |
echo "NODE_OPTIONS=--openssl-legacy-provider" >> $GITHUB_ENV

yarn
yarn run ci
env:
NODE_OPTIONS: "--openssl-legacy-provider"
- name: Build
if: matrix.node-version != '18.x'
run: |

yarn
yarn run ci
- name: Remove openssl-legacy-provider from node options on node v18
if: matrix.node-version == '18.x'
run: |
unset NODE_OPTIONS
# - name: Remove openssl-legacy-provider from node options on node v18
# if: matrix.node-version == '18.x'
# run: |
# unset NODE_OPTIONS
compliance:
Copy link
Member

@bd82 bd82 Oct 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not this mean the compliance step would run for each "element" of the build matrix? This seems like a waste, I would recommand to only run it once in a separate github actions flow.

runs-on: ubuntu-latest
env: