Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle relative imports within framework libs #505

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Handle relative imports within framework libs #505

wants to merge 2 commits into from
+140 −14

Conversation

d3xter666
Copy link
Contributor

This is a test case where library.js is included with raltive path as a module dependency.

Currently relative paths are not resolved properly and definitions from sapui5/types cannot be mapped correctly

@d3xter666 d3xter666 marked this pull request as draft January 28, 2025 11:36
@matz3 matz3 force-pushed the export-lib-rel-path-samples branch from 2a92f28 to f4e2687 Compare February 7, 2025 18:04
@matz3 matz3 changed the title fix: Resolve relative paths for modules fix: Handle relative imports within framework libs Feb 11, 2025
@matz3 matz3 marked this pull request as ready for review February 11, 2025 09:43
@matz3 matz3 requested review from codeworrior and a team February 11, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeworrior codeworrior Awaiting requested review from codeworrior

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d3xter666 @matz3