feat: Detect inline XML fragments & views (reuse TS program) #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3xter666
force-pushed
the
refactor-fragments-detection
branch
from
5205e53 to
ae136f2
Compare
matz3
reviewed
Feb 10, 2025
Comment on lines
+157
to
+162
| await lintXml({ | ||
| filePathsWorkspace: this.#filePathsWorkspace, | ||
| workspace: this.#workspace, | ||
| context: this.#context, | ||
| }); |
There was a problem hiding this comment.
doesn't this lint all files again?
d3xter666
force-pushed
the
refactor-fragments-detection
branch
from
a196c8b to
480249c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-986
This is alternative implementation of #517 by reusing
programinstead of TS transpiling file by file.Note: This change's base is currently #518 as it paves the ground for dynamic addition of resources to the TS program