chore(ui5-input): update border width in high contrast themes #10885
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoplashkov
requested changes
Feb 25, 2025
| @@ -156,6 +156,10 @@ | |||
| visibility: hidden; | |||
| } | |||
|
|
|||
| :host([readonly]) { | |||
| border: var(--_ui5_input_readonly_border); | |||
There was a problem hiding this comment.
When setting this parameter in the base .css file, ensure it resolves to a valid value across all themes. Currently, it is defined for all Horizon themes, but in Fiori and Belize themes, the parameter resolves to "none", causing the border to be removed from readonly inputs.
Screenshot from sap_fiori_3_hcw:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #10871