Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui5-table): migrate hbs to tsx #10911

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore(ui5-table): migrate hbs to tsx #10911

wants to merge 5 commits into from

Conversation

DonkeyCo
Copy link
Member

Migrate all table related Handlebars files to TSX to leverage the newest features

@DonkeyCo
Copy link
Member Author

There is still an issue with TableCell:
TableCell clones the header node, if it is shown in the popin (get _popinHeaderNodes), this property contains an array of strings or an array of DOM nodes.
Putting DOM nodes into handlebars works fine, but in TSX/JSX a JSX.Element is expected, therefore this cloning mechanism doesn't work anymore.

We can either
a) inject unsafe HTML (I don't like this alternative at all)
b) instead of cloning the node, we "only" get the inner text
c) create a dummy cell in the TableCell template filling it with the header text and the action

Or there is maybe another solution? Might need to discuss this

@DonkeyCo DonkeyCo requested a review from aborjinik February 20, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants