Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-toolbar-button): add hidden property #10915

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ui5-toolbar-button): add hidden property #10915

wants to merge 2 commits into from

Conversation

NakataCode
Copy link
Contributor

  • The ToolbarButton component had no hidden property implemented, which meant that buttons could not be dynamically shown or hidden after the initial render.

Fixes: #10585

@NakataCode NakataCode marked this pull request as ready for review February 20, 2025 14:05
@nnaydenow
Copy link
Contributor

This is feature. Please add since tag as well.

@nnaydenow
Copy link
Contributor

Please check if this request will fix the problem as well: #10622

@NakataCode
Copy link
Contributor Author

The hidden property won't fully address 10622. While it improves visibility control, the feature request calls for a shift from template-based to physical DOM elements, which requires switching to conditional rendering based on overflow state.

Also, i made the property private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ToolbarButton: The ToolbarButton has no "hidden" property
2 participants
@NakataCode @nnaydenow