fix(ui5-date-picker): display value state message in the value help #10919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsanislavgatev
requested changes
Feb 25, 2025
| @@ -553,8 +562,8 @@ class DatePicker extends DateComponentBase implements IFormInputElement { | |||
| } | |||
| } | |||
|
|
|||
| _getInput(): Input { | |||
| return this.shadowRoot!.querySelector<Input>("[ui5-input]")!; | |||
| _getInput(): DateTimeInput { | |||
There was a problem hiding this comment.
we can move this to query
|
|
||
| get classes() { | ||
| return { | ||
| popover: { |
There was a problem hiding this comment.
where do we use this?
| return this.valueState !== ValueState.None; | ||
| } | ||
|
|
||
| get classes() { |
There was a problem hiding this comment.
move this to the template
| @@ -193,7 +194,6 @@ class DateTimePicker extends DatePicker implements IFormInputElement { | |||
| /** | |||
| * Read-only getters | |||
| */ | |||
|
|
|||
| get classes() { | |||
There was a problem hiding this comment.
As the comment on 199 states, we should move this to the tsx template, not add more to it and reuse it.
| "ui5-dt-time": true, | ||
| ...this.classes.dateTimeView, | ||
| "ui5-dt-cal": true, | ||
| "ui5-dt-cal--hidden": this.phone && this.showTimeView, |
There was a problem hiding this comment.
You already started moving it here, so continue with this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the valueStateMessage was displayed only below or above the input field, making it less clear when a valueState was active. With this enhancement, the valueStateMessage and its associated valueState styling now also appear in the header of the time selection popover, providing better visibility of the valueState and its provided message.