chore: improve input value handling #10935
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<ui5-input>
has a very complex logic for handlingtype=numeric
, implemented by keeping_innerValue
.This has two issues:
preact
to render a value in the DOM only when it is different from the old value.This fix remove the preact patch returning it to default - if a value is set in the tempate, it will be set in the DOM (for native inputs this will always assign a value from the state, even if it is the same)
By removing the
_innverValue
, apps can automatically set an old value and it will propagate in the DOM.Example before - an input that accepts only three numbers by setting the old value if more than three numbers arrive
Example after - when setting an old value, it will be updated in the inner input, so typing
1234
will correctly result in123
both in.value
property and in DOM.see
Input_old_value.html
for example code