feat(ui5-side-navigation): improve interaction of unselectable parent items in collapsed mode #10939
+103
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… items in collapsed mode
…unselectableparent_popover
dimovpetar
requested review from
alexandar-mitsev,
LidiyaGeorgieva,
TeodorTaushanov and
Stoev
Stoev
reviewed
Feb 24, 2025
There was a problem hiding this comment.
Please consider adding short explanation in the conversation, to enumerate the improvements. For example (I've used Copilot, so pls allow some margin of error in the below example):
- Unselectable parent items now pass focus to their first child.
- Unselectable items in popovers are removed from the tab order.
- When a popover appears, the focus is set to the first selectable child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BGSOFUIRODOPI-3406