Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): invalidation of unchanged slots #10949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nnaydenow
Copy link
Contributor

@nnaydenow nnaydenow commented Feb 25, 2025

Previously, _updateSlots was called twice — once by a DOM observer monitoring the custom element’s DOM node and once by the slot change event triggered inside shadowRoot.

This update enhances the DOM observer to also monitor the slot attribute of each child within the custom element’s DOM node, eliminating the need for an event listener inside shadowRoot.

Fixes: #10377

@DonkeyCo
Copy link
Member

@nnaydenow it seems like TableGrowing.cy is among the tests that are failing for your PR. I've created another PR that solves the issue, you can review it here: #10952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI5Element]: unnecessary invalidation for unchanged slots
2 participants