YZ 2D Simulation and Separate Electron Lifetime Simulation #611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configurations to support new WireCell module to configure eLifetime per TPC
Currently split is configured based on anode dimensions. However, it can be possible to extend the functionality to add custom input / or add separate module depending on required input in the future.
This PR should be merge only with new version of WireCell
This PR suppose to break several upstream features, since it now outputs 8 simchannel versions (2 for each TPC). Numbering should be as following 0-1 : TPCEE , 2-3 : TPCEW , 4-5 : TPCWE , 6-7 : TPCWW. Contact me if this is not working correctly.
For this test I add @gputnam and @SFBayLaser as reviewers. [I will let you know as soon as new WireCell version is available]
Although I did several tests to make sure WC module and configurations are working correctly I suggest more validation to ensure eLifetime is correctly set for appropriate TPC.