Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run number for TPC calibration #699

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

jedori0228
Copy link
Contributor

  • We are passing time stamp to TPC dqdx and YZ calibration DB querying; drift correction module was correctly using run number.
  • Using SQL db as default for TPC calibration

Copy link
Member

@mvicenzi mvicenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mvicenzi
Copy link
Member

Does this solve #693 as well?

@jedori0228
Copy link
Contributor Author

Does this solve #693 as well?

Current develop is same as #694; using PostGres as default, and passing timestamp for YZ and dQ/dX module. We need to cherry-pick 88cc345 and 2566732 there as well. @brucehoward-physics

Copy link

@cfarnese cfarnese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important correction to run data events!

@mmrosenberg
Copy link
Contributor

trigger build

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen, nothing looks wrong, I trust the submitter and the other reviewers on the database actually accepting a run number as a "time" parameter instead of a timestamp.

@mmrosenberg mmrosenberg merged commit e56097f into develop Mar 11, 2024
3 of 4 checks passed
@mmrosenberg mmrosenberg deleted the feature/jskim_UseRunNumForTPCCalib branch March 11, 2024 21:04
mmrosenberg added a commit that referenced this pull request Jun 12, 2024
…from_gputnam-configs_CherrypickPR699

Cherry-picked #699 to feature/howard_forNuMI2023A_from_gputnam-configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants