Feature/howard v09 72 00 08 harps #791
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, to be tested and used with SBN2023a series releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the best way to have code for a data cross-check approved without actually merging it into the code base at the moment, but figure maybe getting some sort of branch which has undergone "approvals" or "checking over" might be a good start. Hence, making this draft PR as we don't actually want to merge it yet, but to have it checked out. Someone should let me know if they think of a better procedure.
Tagging Alice and Joseph as reviewers for the moment due to relevant reconstruction and icaruscode/larsoft expertise. Maybe someone like Dom Brailsford would also be a good reviewer especially on the Pandora side: perhaps we should add him.
This is the icaruscode repo version -- just tagging Alice for now on the Pandora repos, but with above caveat.
HARPS module put together largely by @hausnerh and myself. The XMLs are to run Pandora on the post-HARPS events. The calibration changes are from updates by @jedori0228 based on work by folks in the calibration group (I think London?) to allow the normalization data calibrations on planes other than collection. (Note that there is a database file missing from this branch which is needed for said normalization).
The fhicls I've used to control the HARPS and post-HARPS reco have typically been part of my tarballs that I send to the grid, but I would happy to provide some examples to look at as well as part of any checks here.
At some point we will actually want to merge this tool into icaruscode for broader use.