Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy cafe to build directory so we don't have to run mrbslp #110

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Copy cafe to build directory so we don't have to run mrbslp #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cbff57
Copy cafe to build directory so we don't have to run mrbslp everytime…
jedori0228 Jan 19, 2024
a250d11
Use SBNANA_DIR to find rootlogon
jedori0228 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sbnana/SBNAna/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ add_definitions(-Wno-vla)
# add_subdirectory(Analysis)
# add_subdirectory(Systs)

cet_script(cafe)
cet_script(cafe ALWAYS_COPY)
# same place as cafe script so we can find it
cet_script(load_cafana_libs.C)
#cet_script(rootlogon.C)
Expand Down
2 changes: 1 addition & 1 deletion sbnana/SBNAna/load_cafana_libs.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void load_cafana_libs()
gROOT->Macro("${SBNANA_FQ_DIR}/bin/rootlogon.C");
}
else{
gROOT->Macro("${MRB_BUILDDIR}/sbnana/bin/rootlogon.C");
gROOT->Macro("${SBNANA_DIR}/sbnana/CAFAna/rootlogon.C");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new version appears to mirror the setup strategy in cafe script.
Nevertheless I do not understand the motivation of this change. Can you explain?

Copy link
Contributor Author

@jedori0228 jedori0228 Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this PR, users ran mrbslp before they run cafe. ${SBNANA_FQ_DIR} is only set after mrbslp, and for this case it looks for "${SBNANA_FQ_DIR}/bin/rootlogon.C" which exists. This PR helps user to run cafe without running mrbslp, and there we have empty ${SBNANA_FQ_DIR}. I then found we don't have "${MRB_BUILDDIR}/sbnana/bin/rootlogon.C", but it exists under "${SBNANA_DIR}/sbnana/CAFAna/rootlogon.C"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While checking more on this, it looks like just using tagged sbnana with setup sbnana v09_75_03 -qe20:prof does not suffer from this issue, where most of the users (I guess) check out the product and use local products

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you setup sbnana (either explicitly or indirectly with mrbslp), SBNANA_FQ_DIR is set so this part of the code would be skipped. That could explain your last statement.

}
gROOT->ForceStyle();

Expand Down