Feature/jlarkin numu selection #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jacob, this looks like exactly what we talked about to me. I'll approve, but maybe give Chris a chance to look at the code before you merge |
etworcester
approved these changes
Aug 2, 2022
cjbacchus
approved these changes
Aug 4, 2022
Comment on lines
+22
to
+32
| const SpillVar dummy_var([&out](const caf::SRSpillProxy* spill){ | ||
| for(const auto& slc: spill->slc) { | ||
| if(kIcarus202208QELikeContainedMuon(&slc)) { | ||
| out << "Run: " << spill->hdr.run << "\tSubrun: " << spill->hdr.subrun | ||
| << "\tEvent: " << spill->hdr.evt << "\tVertex: (" | ||
| << slc.vertex.x << ", " << slc.vertex.y << ", " << slc.vertex.z << ")\n"; | ||
| return 1; | ||
| } | ||
| } | ||
| return 0; | ||
| }); |
There was a problem hiding this comment.
This works, and I guess I can't fault you for not using EventList since it doesn't exist in SBNAna yet ;)
See issue #56
| #include "sbnana/SBNAna/Cuts/NumuCutsIcarus202208.h" | ||
| #include "sbnana/SBNAna/Vars/NumuVarsIcarus202208.h" | ||
|
|
||
| #include "sbnanaobj/StandardRecord/Proxy/FwdDeclare.h" |
There was a problem hiding this comment.
No need for the fwd declare when you're actually including the whole thing on the next line anyway.
|
|
||
| namespace ana { | ||
|
|
||
| static bool contained(const caf::SRTrackProxy& trk) |
There was a problem hiding this comment.
Put Icarus202208 here too before it clashes with something.
| return PTrackInd; | ||
| }); | ||
|
|
||
| static bool proton_cut(const caf::SRTrackProxy& trk) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new selection for Icarus Numu
I tried to add Icarus202208 in front of all names to avoid naming conflicts with other Vars and Cuts.
I also added a CAFAna macro which prints the run, subrun, and event number for events with selected slices. This macro is intended to find events for the scanning group to look at.