-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External cafanacore, and switch to RecordSource-based loading #85
Draft
cjbacchus
wants to merge
152
commits into
develop
Choose a base branch
from
feature/ext_cafanacore
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done outside of git (git diff, slight automated rewrite, patch). Next step is to see if any of this compiles.
This was done outside of git (git diff, slight automated rewrite, patch). Next step is to see if any of this compiles.
Conflicts: sbnana/CAFAna/Core/MultiVar.cxx sbnana/CAFAna/Core/MultiVar.h
There is some remaining problem with linking to GSL?
…a into feature/ext_cafanacore
…nch is now merged into cafanacore trunk, both now depend on the new version of stan_math, and the implicit nutools dependency is encoded in the n309 qualifier.
…a into feature/ext_cafanacore
…d by SliceCut subscript.
Migrating Covariance and Bias Matrix Calculation to Eigen
…clude the multiverse.
Add ReplicatedData to EnsembleSpectrum
…atest cafanacore.
…format. This is done by updating to srproxy v00.36 - which currently requires to use the feature/srproxy_v36 branch of sbnanaobj.
Related to discussion in SBNSoftware/sbncode#264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wesketchum this is the RecordSource branch. It works for what it is, and @etyley has been using it extensively, but it would break the oscillation analysis as it stands.
You can tell it's good because it removes 4000 lines on net :)