Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External cafanacore, and switch to RecordSource-based loading #85

Draft
wants to merge 152 commits into
base: develop
Choose a base branch
from

Conversation

cjbacchus
Copy link
Contributor

@cjbacchus cjbacchus commented Sep 9, 2022

@wesketchum this is the RecordSource branch. It works for what it is, and @etyley has been using it extensively, but it would break the oscillation analysis as it stands.

You can tell it's good because it removes 4000 lines on net :)

This was done outside of git (git diff, slight automated rewrite, patch).
Next step is to see if any of this compiles.
This was done outside of git (git diff, slight automated rewrite, patch).
Next step is to see if any of this compiles.
Conflicts:
	sbnana/CAFAna/Core/MultiVar.cxx
	sbnana/CAFAna/Core/MultiVar.h
There is some remaining problem with linking to GSL?
…nch is now merged into cafanacore trunk, both now depend on the new version of stan_math, and the implicit nutools dependency is encoded in the n309 qualifier.
cjbacchus and others added 26 commits June 8, 2022 08:59
Migrating Covariance and Bias Matrix Calculation to Eigen
…format. This is done by updating to srproxy v00.36 - which currently requires to use the feature/srproxy_v36 branch of sbnanaobj.
@wesketchum
Copy link
Contributor

Related to discussion in SBNSoftware/sbncode#264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants