Feature/howard spillquality #109
Conversation
… the spill quality for the spill that goes with a given event.
brucehoward-physics
requested review from
gputnam,
jzennamo,
jacoblarkin,
PetrilloAtWork and
jzettle
brucehoward-physics
changed the base branch from
develop
to
release_v09_20_06
|
Per @PetrilloAtWork request to make things less confusing (even if we still have to figure out about the differences between this and develop) I've changed the base branch to be |
|
For the release managers (@miquelnebot): I think that the content of this PR it targeted to be permanently in the release, i.e. to be merged in a |
|
Since I got an email from @PetrilloAtWork's comment I will also ask how this meshes with other similar PR's on this topic such as #123? That one is at least targeted to some version of SBN2023A and begs a similar question about what this is targeting and whether there is the intent (or there exists) a parallel request for develop |
|
I have not tried, I use the excuse that these things are hard to keep track of and then I get an email from a comment here from a review I didn't actually do and wonder what happened |
|
so, if aleready in develop e0d9f69 |
Putting together PR for a couple of spill info updates to try to get things into the CAFs and in a way that we can also start to do beam quality cuts.
This goes along with SBNSoftware/sbncode#390 and as there see some info in doc-33224 slides 5-13.
IMPORTANT (!!) -- As with the other PR, I'm not sure if I should be making this PR against develop or v09_72_00_05 e.g. There seem to be a lot of commits present in the latter but not in develop as my changes are only the last commit...