Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NearestWireID #461

Merged
merged 1 commit into from
May 8, 2024
Merged

Update NearestWireID #461

merged 1 commit into from
May 8, 2024

Conversation

bear-is-asleep
Copy link
Contributor

Fixed bug where out of bounds IDs set TPC and Plane info to bad values.

@bear-is-asleep
Update NearestWireID
7823a7f 
Fixed bug where out of bounds IDs set TPC and Plane info to bad values.
@bear-is-asleep bear-is-asleep self-assigned this May 6, 2024
@bear-is-asleep bear-is-asleep requested a review from SFBayLaser May 6, 2024 18:14
SFBayLaser
SFBayLaser approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@SFBayLaser SFBayLaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a really bizarre problem! But it looks like this solves the problem so all good!

@bear-is-asleep
Copy link
Contributor Author

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@ibsafa ibsafa merged commit 5c4c3ca into develop May 8, 2024
2 of 6 checks passed
@bear-is-asleep bear-is-asleep mentioned this pull request May 17, 2024
Open
@bear-is-asleep
Copy link
Contributor Author

Related to #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SFBayLaser SFBayLaser SFBayLaser approved these changes

Assignees

@bear-is-asleep bear-is-asleep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bear-is-asleep @FNALbuild @SFBayLaser @ibsafa