Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables #465

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bear-is-asleep
Copy link
Contributor

Unused variables cause misallocated memories, and segmentation faults within cluster3D.

Unused variables cause misallocated memories, and segmentation faults within cluster3D.
@bear-is-asleep bear-is-asleep self-assigned this May 15, 2024
@bear-is-asleep bear-is-asleep requested a review from SFBayLaser May 15, 2024 15:19
@bear-is-asleep
Copy link
Contributor Author

This fixes a lot of seg fault instances I've seen in Cluster3D. Further debugging is needed to fix them all.

@ibsafa
Copy link
Contributor

ibsafa commented May 16, 2024

@bear-is-asleep since more debugging is needed in the future, can you please create an issue and link this PR to it so we can keep track of all updates related to Cluser3D?

@ibsafa
Copy link
Contributor

ibsafa commented May 16, 2024

trigger build

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep
Copy link
Contributor Author

Related to #466

@bear-is-asleep bear-is-asleep marked this pull request as draft May 21, 2024 23:05
@ibsafa
Copy link
Contributor

ibsafa commented May 22, 2024

@bear-is-asleep i see you turned this into a draft. Is the PR as is not ready to be merged? Or do you want to fix all the segfault issues before merging everything at once?

@bear-is-asleep
Copy link
Contributor Author

@bear-is-asleep i see you turned this into a draft. Is the PR as is not ready to be merged? Or do you want to fix all the segfault issues before merging everything at once?

It caused a really strange issue where downstream TTrees are not filled from analyzer modules (i.e. Supera). So it's not ready to be merged since it breaks Supera.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants