-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused variables #465
base: develop
Are you sure you want to change the base?
Conversation
Unused variables cause misallocated memories, and segmentation faults within cluster3D.
This fixes a lot of seg fault instances I've seen in Cluster3D. Further debugging is needed to fix them all. |
@bear-is-asleep since more debugging is needed in the future, can you please create an issue and link this PR to it so we can keep track of all updates related to Cluser3D? |
trigger build |
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
Related to #466 |
@bear-is-asleep i see you turned this into a draft. Is the PR as is not ready to be merged? Or do you want to fix all the segfault issues before merging everything at once? |
It caused a really strange issue where downstream TTrees are not filled from analyzer modules (i.e. Supera). So it's not ready to be merged since it breaks Supera. |
Unused variables cause misallocated memories, and segmentation faults within cluster3D.