Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reassign CRT-PMT MatchID while filling CAFs [release/SBN2024A] #483

Open
wants to merge 5 commits into
base: release/SBN2024A
Choose a base branch
from

Conversation

aheggest
Copy link
Contributor

This is a copy of sbncode PR#482 for the production branch. Please note this PR is dependent on sbnobj PR#115.

@aheggest aheggest self-assigned this Nov 12, 2024
@aheggest aheggest added the enhancement New feature or request label Nov 12, 2024
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!
Formally a bit different from the develop version (I'd argue: "better"), so if a merge happens some work will be needed.
[edit: actually if this is exactly the same as the other PR, plus one commit, then it should work smoothly]

@aheggest
Copy link
Contributor Author

Thank you for the review @PetrilloAtWork!! Yes, the develop version of this PR was merged in on Dec 3rd. I added an additional PR to address your final comments here in sbncode PR#489. Develop sbncode PR #482, along with develop sbncode PR #489, should be the same as this production sbncode PR #483. (so yes, #483 = #482 + #489). please let me know if this isn't clear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants