Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests to use WireCell workflow #414

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

fjnicolas
Copy link
Contributor

@fjnicolas fjnicolas commented Feb 16, 2024

Intended to match #409

@fjnicolas fjnicolas changed the title Feature/fnicolas fix unit tests Update unit tests to use WireCell workflow Feb 16, 2024
@fjnicolas
Copy link
Contributor Author

trigger build

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase unit_test SBND on slf7 for c14:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the unit_test SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@lynnt20
Copy link
Contributor

lynnt20 commented Feb 16, 2024

Looks like the CI is still calling the old version of standard_g4_sbnd.fcl that includes mcreco. I think this may be expected?

@lynnt20
Copy link
Contributor

lynnt20 commented Feb 18, 2024

Found another instance of mcreco in a g4 stage, in g4_dirt_filter.fcl. Unsure if this is the cause for the unit test failure, but I commented it out in the following commit.

Copy link
Member

@henrylay97 henrylay97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good to me - once it's been shown Lynn's commit solves the failure.

@lynnt20 I notice some of the wirecell fcls have quite a lot of "other detsim things" commented out? Not necessarily one for this PR but might be worth removing to avoid confusion?

@fjnicolas
Copy link
Contributor Author

Looks like the CI is still calling the old version of standard_g4_sbnd.fcl that includes mcreco. I think this may be expected?

@lynnt20 what test do you mean? This PR only fixes the unit tests (they look fine to me in the previous build, other than the known issue with c14 and CAF maker #407). The fix for the CI is not addressed here (coming PR from Rachel).

@lynnt20
Copy link
Contributor

lynnt20 commented Feb 19, 2024

@fjnicolas oh I see, I misunderstood!! Everything looks good to me then!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants