-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unit tests to use WireCell workflow #414
Conversation
trigger build |
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
❌ CI build for SBND Failed at phase unit_test SBND on slf7 for c14:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the unit_test SBND phase logs parent CI build details are available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
Looks like the CI is still calling the old version of |
Found another instance of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looks good to me - once it's been shown Lynn's commit solves the failure.
@lynnt20 I notice some of the wirecell fcls have quite a lot of "other detsim things" commented out? Not necessarily one for this PR but might be worth removing to avoid confusion?
@lynnt20 what test do you mean? This PR only fixes the unit tests (they look fine to me in the previous build, other than the known issue with |
@fjnicolas oh I see, I misunderstood!! Everything looks good to me then!! |
Intended to match #409