Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CVN model #563

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from

Conversation

yangtj207
Copy link
Contributor

@yangtj207 yangtj207 commented Nov 29, 2024

Description

Integrate CVN model.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
#562

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=34180

@yangtj207 yangtj207 added the tpc Time Projection Chamber label Nov 29, 2024
@yangtj207 yangtj207 self-assigned this Nov 29, 2024
@bear-is-asleep bear-is-asleep mentioned this pull request Dec 1, 2024
4 tasks
@yangtj207 yangtj207 requested a review from absolution1 December 9, 2024 01:35
@yangtj207
Copy link
Contributor Author

I included cvn to the reco2 stage for data and MC workflows. Some initial tests look OK.

Copy link
Contributor

@absolution1 absolution1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thank you @yangtj207

@yangtj207 yangtj207 marked this pull request as draft December 9, 2024 17:04
@yangtj207
Copy link
Contributor Author

I need to make some changes to make it work with cafana. Mostly to change SBNDPixelMap (only available in sbndcode) to PixelMap (available in larsoft).

@yangtj207 yangtj207 closed this Dec 9, 2024
@yangtj207 yangtj207 deleted the feature/tjyang_cvn branch December 9, 2024 21:03
@yangtj207 yangtj207 restored the feature/tjyang_cvn branch December 10, 2024 14:58
@yangtj207
Copy link
Contributor Author

I accidentally deleted this branch. I will resubmit the PR once the cafana integration is finished.

@yangtj207 yangtj207 reopened this Dec 11, 2024
@yangtj207
Copy link
Contributor Author

This PR is ready to be reviewed and merged.

@yangtj207 yangtj207 marked this pull request as ready for review December 12, 2024 14:47
@bear-is-asleep bear-is-asleep mentioned this pull request Dec 16, 2024
4 tasks
@RachelCoackley
Copy link
Contributor

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p01 SBNSoftware/sbndcode@v09_93_01_01 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_02 SBNSoftware/sbnobj@v09_19_05

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@RachelCoackley
Copy link
Contributor

@yangtj207 please would you be able to resolve the conflicts? Thanks!! :)

@yangtj207
Copy link
Contributor Author

@yangtj207 please would you be able to resolve the conflicts? Thanks!! :)
Hi @RachelCoackley, I think with git push --force, the conflict is resolved. Please let me know if there are other issues. Thanks.

@bear-is-asleep
Copy link
Contributor

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p02 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03 SBNSoftware/sbnobj@v09_19_05

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tpc Time Projection Chamber
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants