Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRT data fcl updates #591

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

henrylay97
Copy link
Member

@henrylay97 henrylay97 commented Jan 7, 2025

Description

Two minor changes to fcls relating to CRT data reconstruction.

  1. Allow tracks to be made using the bottom CRT
    • This was turned off during some commissioning studies early on to reduce the reconstruction rate while we understood things further up our priority list. This can now be undone.
  2. Don't drop the RawEventHeader objects in the CRT-only reco workflow.
    • We were dropping all the fragments from the event. We would like to retain this particular fragment as it allows us to undo timing referencing if we want to. Note, this does not affect the standard data reconstruction workflow (reco1_data.fcl and reco2_data.fcl) where currently all fragments are being retained. This only impacts the CRT only workflow used internally by the CRT group.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

None

Link(s) to docdb describing changes (optional)

None

@henrylay97 henrylay97 added maintenance reco1/reco2 Reconstruction data features for data processing labels Jan 7, 2025
@henrylay97 henrylay97 self-assigned this Jan 7, 2025
Copy link
Contributor

@bear-is-asleep bear-is-asleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure if I'm the person to approve, but the changes look sensible given the goals laid out in the description. Thanks!

@henrylay97
Copy link
Member Author

Yeah - sorry there isn't really anyone appropriate to review this. But they're very minor changes.

@bear-is-asleep
Copy link
Contributor

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p02 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03 SBNSoftware/sbnobj@v09_19_05

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@bear-is-asleep
Copy link
Contributor

Approved - The CI has done it's job, warnings are from outdated references.

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data features for data processing maintenance reco1/reco2 Reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants