-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRT data fcl updates #591
base: develop
Are you sure you want to change the base?
CRT data fcl updates #591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if I'm the person to approve, but the changes look sensible given the goals laid out in the description. Thanks!
Yeah - sorry there isn't really anyone appropriate to review this. But they're very minor changes. |
trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p02 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03 SBNSoftware/sbnobj@v09_19_05 |
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
Approved - The CI has done it's job, warnings are from outdated references. |
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
Description
Two minor changes to fcls relating to CRT data reconstruction.
RawEventHeader
objects in the CRT-only reco workflow.reco1_data.fcl
andreco2_data.fcl
) where currently all fragments are being retained. This only impacts the CRT only workflow used internally by the CRT group.Checklist
Reviewers
,Assignees
Developement
Relevant PR links (optional)
None
Link(s) to docdb describing changes (optional)
None