Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated list of unresponsive channels #596

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

marcodeltutto
Copy link
Member

@marcodeltutto marcodeltutto commented Jan 15, 2025

Description

This PR updates the list of unresoonsive channels in data with channels 8395 and 11147.
Fixes #594.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Link(s) to docdb describing changes (optional)

Tom's prensentation on unresponsive channels: docdb 39446.

@marcodeltutto marcodeltutto added detsim Detector simulation data features for data processing labels Jan 15, 2025
@marcodeltutto marcodeltutto requested a review from tomjunk January 15, 2025 20:38
@marcodeltutto marcodeltutto self-assigned this Jan 15, 2025
@lynnt20
Copy link
Contributor

lynnt20 commented Jan 15, 2025

@marcodeltutto sorry I was being nosy in the PRs... we also will need to update the bad channels in the WireCell config; located in sbndcode/WireCell/cfg/pgrapher/experiment/sbnd/chndb-base.jsonnet; I can volunteer to make the commit in this branch if you'd like!

@marcodeltutto
Copy link
Member Author

Hi @lynnt20, thanks so much for spotting this!! Yes, please, go ahead.

Does WireCell uses this set of bad channels for both data and simulation?

@marcodeltutto marcodeltutto requested a review from lynnt20 January 15, 2025 21:04
@lynnt20
Copy link
Contributor

lynnt20 commented Jan 15, 2025

This list of bad channels will be used in the signal processing stage for both data and simulation yes!

@bear-is-asleep
Copy link
Contributor

@marcodeltutto there's now some conflicts that need to be resolved manually.

@marcodeltutto
Copy link
Member Author

@lynnt20 Could you please resolve them? Thanks!

@lynnt20
Copy link
Contributor

lynnt20 commented Jan 24, 2025

all done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data features for data processing detsim Detector simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Unresponsive TPC Channels List
3 participants