Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No SCE reco2 fcl for Calib workflow #604

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

No SCE reco2 fcl for Calib workflow #604

wants to merge 12 commits into from

Conversation

henrylay97
Copy link
Member

Replacing #544 following merge problems. See historical discussion there for contents of PR (but it basically does what it says on the tin).

bear-is-asleep
bear-is-asleep requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@bear-is-asleep bear-is-asleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions. I'm rejecting the changes since I think we want to keep reco_sbnd.fcl. Correct me if I'm wrong though.

sbndcode/JobConfigurations/base/reco_sbnd.fcl Outdated Show resolved Hide resolved
sbndcode/JobConfigurations/standard/reco/config/workflow_reco2.fcl Show resolved Hide resolved
sbndcode/JobConfigurations/standard/standard_reco1reco2_sbnd.fcl Outdated Show resolved Hide resolved
@henrylay97
Copy link
Member Author

Thanks for the review @bear-is-asleep. I have responded to all :)

bear-is-asleep
bear-is-asleep approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@bear-is-asleep bear-is-asleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments have been addressed, thanks @henrylay97

linyan-w
linyan-w approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Henry!

@bear-is-asleep
Copy link
Contributor

trigger build RachelCoackley/larreco>larreco@v09_93_01rachel LArSoft/lar*@LARSOFT_SUITE_v09_93_01 SBNSoftware/sbncode@v09_93_01_p02 SBNSoftware/sbnanaobj@bug/coackley_ciCafv09_91_02 SBNSoftware/sbndaq-artdaq-core@v1_10_03 SBNSoftware/sbnobj@v09_19_05

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bear-is-asleep bear-is-asleep bear-is-asleep approved these changes

@linyan-w linyan-w linyan-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrylay97 @bear-is-asleep @FNALbuild @linyan-w