Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SBNDOpHitFinder to allow for a channel-dependent threshold #605

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

asanchezcastillo
Copy link
Contributor

@asanchezcastillo asanchezcastillo commented Jan 22, 2025

Description

This PR modifies SBNDOpHitFinder to allow for a channel dependent ADCThreshold. This changes is made to mee the needs presented at docdb-39495 . This is a temporary fix that runs the peak finding algorithm with the lowest ADCThreshold of the list and then only saves the OpHits that pass the ADCThreshold for each channel. Ideally, the peak finder algorithm should be run for each channel with and independent threshold, which is not possible with the current implementation of the algorithm in larana. This PR in larana implements the required changes to larana, but will require migrating sbndcode to larsoft v10.

As soon as the larana PR is merged and sbndcode migrated to larsoft v10 this modification can be reverted and updated to match the definitive implementation.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
docdb-39495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant