Modify SBNDOpHitFinder to allow for a channel-dependent threshold #605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies SBNDOpHitFinder to allow for a channel dependent ADCThreshold. This changes is made to mee the needs presented at docdb-39495 . This is a temporary fix that runs the peak finding algorithm with the lowest ADCThreshold of the list and then only saves the OpHits that pass the ADCThreshold for each channel. Ideally, the peak finder algorithm should be run for each channel with and independent threshold, which is not possible with the current implementation of the algorithm in larana. This PR in larana implements the required changes to larana, but will require migrating sbndcode to larsoft v10.
As soon as the larana PR is merged and sbndcode migrated to larsoft v10 this modification can be reverted and updated to match the definitive implementation.
Checklist
Reviewers
,Assignees
Developement
Relevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?
docdb-39495