Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WireCell NF+SP updates (teardrop mitigation) #606

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

WireCell NF+SP updates (teardrop mitigation) #606

wants to merge 6 commits into from
+26 −10

Conversation

lynnt20
Copy link
Contributor

@lynnt20 lynnt20 commented Jan 24, 2025 •
edited
Loading

Description

Teardrop Mitigation

  • update coherent noise filtering channel grouping to match reality
  • update one signal processing filter value: loose low-frequency filter for ROI finding, unrelated to TPC 2D deconvolution. Value is increased to remove residual low-frequency noise present in data.

Generic updates

  • turn on coherent noise filtering for simulation
  • update number of ticks for depofluxwriter
  • update front porch size (from 400 -> 405 ticks) to match data since August 2024.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • [N/A] Linked any relevant issues under Developement
  • [N/A] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Link(s) to docdb describing changes (optional)

docdb39640

@lynnt20 lynnt20 added tpc Time Projection Chamber data features for data processing labels Jan 24, 2025
@lynnt20 lynnt20 self-assigned this Jan 24, 2025
@lynnt20 lynnt20 requested a review from weihythu January 29, 2025 14:52
@lynnt20 lynnt20 marked this pull request as ready for review January 29, 2025 14:53
weihythu
weihythu approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@weihythu weihythu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihythu weihythu weihythu approved these changes

Assignees

@lynnt20 lynnt20

Labels
data features for data processing tpc Time Projection Chamber
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lynnt20 @weihythu