Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Fcls for the New Geometry Handling #608

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

jzennamo
Copy link
Contributor

@jzennamo jzennamo commented Jan 27, 2025

Description

I have updated three fcls that needed to have their Geometry Service connections updated to address the new LArSoft refactoring for the v10 transition

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow? Yes!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

This is based off feature/geom

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

Not yet.

@jzennamo jzennamo added the bug Something isn't working label Jan 27, 2025
Copy link
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on this new geometry, but it seems to me your changes are consistent with the rest of the branch.
But I would suggest to create a geometry configuration table in geometry_sbnd.fcl bundling all this stuff together, something like:

geometry_services_sbnd: {
  GeometryConfigurationWriter: {}
  Geometry:                    @local::sbnd_geo
  WireReadout:                 @local::sbnd_wire_readout
  AuxDetGeometry:              @local::sbnd_auxdetgeo
}

so that configurations can get away with just

services: {
  # ...
  @table::geometry_services_sbnd
  # ...
}

Note that if this approach had been already adopted, this PR would not have been necessary at all.

@jzennamo
Copy link
Contributor Author

@PetrilloAtWork this is a fair suggestion, maybe we can consider this as part of a future PR.

@wjdanswjddl I tested these fcls on data directly and they worked!

@bear-is-asleep
Copy link
Contributor

Approved, this is a PR directly to another feature branch.

@bear-is-asleep bear-is-asleep merged commit e1178e5 into feature/geom Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants