Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbn::ExtraTriggerInfo: added cryostat trigger information #110

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

PetrilloAtWork
Copy link
Member

@PetrilloAtWork PetrilloAtWork commented May 21, 2024

ICARUS trigger hardware is going to contribute one additional information (see e.g. SBNDocDB 36096 or 36264).

This PR extends the sbn::ExtraTriggerInfo data product to accommodate for that new information, that is the time from the opening of the beam gate at which the hardware sees the trigger. This is a more direct quantification of that time than with the White Rabbit timestamp, because once the hardware takes the trigger decision, this time is frozen by the very same hardware, while it takes further time (and jitters) for the decision to reach the timestamping hardware. In the ICARUS hardware the time is measured in FPGA ticks, but the data product should store it in nanoseconds, delegating the decoding of the value upstream.
The protocol is a default value NoTrigger that denotes the absence of this information, a class method to test its availability (hasTrigger()), and direct access to the data member value (beamToTrigger).

The change is backward-compatible in that old data will look like they don't have this part of the trigger information. However, the additional information is mostly diagnostics for trigger study and performance evaluation, and I don't foresee physics analyses directly using it.

Reviewers:

@dtorretta56
Copy link

OK to proceed in implementing the changes.

Copy link
Member

@mvicenzi mvicenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Plus, this code has already been tested and used throughout the last few months for extensive diagnostic studies.

@ibsafa ibsafa merged commit 141d1e1 into SBNSoftware:develop Dec 3, 2024
@PetrilloAtWork PetrilloAtWork deleted the feature/gp_triggerTicks branch December 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants