Add sorting to the list of paths before storing them to the golden copy #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absolute path of a filespec.
the golden copies. With --update param, now the golden copies are updated only if: - The golden copy doesn't exists - The file paths are different than those in the golden copies. If a list of paths have the same paths but different order than ones in the golden copy, they will be considered the same. And we won't update the golden copy in this case.
rfrenchseti
requested changes
Sep 12, 2024
rfrenchseti
requested changes
Sep 12, 2024
pdsfile/pdsfile_test_helper.py
Outdated
| with open(path, 'w') as f: | ||
| pprint.pp(data, stream=f) | ||
| print('\nCreate the golden copy', path) | ||
| # If the update param is given, compare the file first to make sure we don't write |
There was a problem hiding this comment.
Why do we need to do this? If the output is sorted properly, writing a new output file with identical content is fine.
by 'group' and then 'prority' just like the original opus products outputs.
…esults_dictionary_before_storing_to_golden_copy
by 'group' and 'priority'.
rfrenchseti
requested changes
Sep 19, 2024
pdsfile/pdsfile_test_helper.py
Outdated
| import ast | ||
| from collections import OrderedDict |
There was a problem hiding this comment.
We don't need to use OrderedDict. Python 3 guarantees that the order of dictionary keys will stay the same. This was only needed for Python 2.
pdsfile/pdsfile_test_helper.py
Outdated
| @@ -39,22 +40,41 @@ def read_or_update_golden_copy(data, path, update): | |||
| """ | |||
|
|
|||
| path = Path(path) | |||
| # Create the golden copy by using the current output | |||
| # Create the golden copy by using the current output if or the update param is given | |||
There was a problem hiding this comment.
Remove "if OR the update"
pdsfile/pdsfile_test_helper.py
Outdated
| return read_file(path) | ||
|
|
||
| def read_file(path): | ||
| """Return data from the read file |
There was a problem hiding this comment.
BTW if we're going to start putting docstrings in, we should make them in Google Docstyle format. Less work to do later to change them.
…e_storing_to_golden_copy
rfrenchseti
approved these changes
Sep 20, 2024
rfrenchseti
deleted the
add_sorting_to_test_results_dictionary_before_storing_to_golden_copy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
--updateparam, now the golden copies are updated only if: