-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create shelves files for pds4 #57
base: main
Are you sure you want to change the base?
Conversation
absolute path of a filespec.
checksums-bundles directory for pds4
_infoshelf-bundles
_linkshelf-* directory
The |
For metadata, you're just talking about the index files in |
I don't see any reason to skip |
Before you get too far into |
Thinking more about this, we also can't ignore the |
checksums, infoshelf, and linkshelf files.
file is in that label's file_name tags. (line 323-336, pds4linkshelf.py)
directory (line 149-154, pds4linkshelf.py)
files that don't exist in the label nor exist in the csv. They are not part of the archive, so they don't have labels. (line 369-378 in pds4linkshelf.py)
Update the latest status on the top comments (10/12/24) Current pending items:
|
Fixed |
Fixed |
Fixed |
in the file_name tags and avoid capturing the file name in the title tag of the label. This will prevent us from getting duplicated file name of the LinkInfo object when the file name exists in the title tag.
pds4linkshelf.py.
- moving the intelligence to check if a file is in the file_name tag of a label. Now this step is done after checking whether the file is in the label_dict already. - moving the intelligence to check if a file is in the collection csv files. Now this step is done right before raising an error when we can't find its corresponding label. These two modifications can avoid unnecessary looping of linkinfo_dict and collection_basename_dict.
when trying to parse each entry to get the basename of a file in the archive.
Update the latest status, the top comments are also updated (10/22/24)
|
Current status of creating shevles files for pds4:
Create files in checksums-* directory (
pds4checksums.py
)BUNDLENAME_REGEX
python holdings_maintenance/pds4/pds4checksums.py --init /Volumes/rms-holdings/pds4-holdings/bundles/uranus_occs_earthbased
python holdings_maintenance/pds4/pds4checksums.py --init /Volumes/rms-holdings/pds4-holdings/metadata/uranus_occs_earthbased
python holdings_maintenance/pds4/pds4checksums.py --init /Volumes/rms-holdings/pds4-holdings/diagrams/uranus_occs_earthbased
Create files in _infoshelf-* directory (
pds4infoshelf.py
), corresponding checksums files from the above steps are requiredpds4checksums
python holdings_maintenance/pds4/pds4infoshelf.py --init /Volumes/rms-holdings/pds4-holdings/bundles/uranus_occs_earthbased
python holdings_maintenance/pds4/pds4infoshelf.py --init /Volumes/rms-holdings/pds4-holdings/metadata/uranus_occs_earthbased
python holdings_maintenance/pds4/pds4infoshelf.py --init /Volumes/rms-holdings/pds4-holdings/diagrams/uranus_occs_earthbased
Create files in _indexshelf-metadata (
pds4indexshelf.py
)BUNDLENAME_REGEX
to Pds3File & Pds4File classes since they are different for pds3 & pds4IDX_EXT
andLBL_EXT
to Pds3File & Pds4File to replace '.tab' & '.lbl' inpdsfile.py
.xml
and idx extension is.csv
.lbl
and idx extension is.tab
Create files in _linkshelf-* directory (
pds4linkshelf.py
).TXT
inEXTS_WO_LABELS
,.TXT
could have a label in pds4python holdings_maintenance/pds4/pds4linkshelf.py --init /Volumes/rms-holdings/pds4-holdings/bundles/uranus_occs_earthbased
Pending items:
pds4indexshelf.py
to create_indexshelf-metadata
for pds4pds4linkshelf.py
to create_linkshelf-metadata
for pds4use_shelves_only
set to TrueNote:
ring_models
and_support
are included when running the scripts.