-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2MASS 0415 Ingest #565
2MASS 0415 Ingest #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good code but too automated for this particular use case. For this situation, do each ingestion one-by-one.
"regime": "nir", | ||
"telescope": "AKARI", | ||
"instrument": "IRC", | ||
"mode": "NIR", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through the paper and I found that this observation was taken in mode "IRC04".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the mode should be IRC04, not NIR
Co-authored-by: Kelle Cruz <[email protected]>
Co-authored-by: Kelle Cruz <[email protected]>
Co-authored-by: Kelle Cruz <[email protected]>
Co-authored-by: Kelle Cruz <[email protected]>
Submitted new edits to the ingest script. Updated JSON files as well to include necessary references for AKARI. |
All test pass now! Updated the following lines in test_data.py to update the number of spectra to be found in the database.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great! Just a few data fixes.
Ingested the publication for the IRC instrument. Added details to the AKARI telescope entry. Corrected the regime values for the LRIS KECK spectra to optical from nir. Adjusted test_data.py file to reflect these changes so all tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'll update the Versions table and make a new release.
Short description: Ingest of 2MASS 0415-09. Updates the Burg03 IRTF data within the JSON file, adds the AKARI (Sora12), FIRE (Simc13), KECK I LRIS (Burg04), and KECK I LRIS (Kirk08) data using a new script.
Link to relevant issue: Closes #559 & #375
For data ingests:
[x] includes script used for ingest
[x ] includes modified JSON files
[ ] Add new tests
[ ] Update the Versions table