Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2MASS 0415 Ingest #565

Merged
merged 10 commits into from
Nov 19, 2024
Merged

2MASS 0415 Ingest #565

merged 10 commits into from
Nov 19, 2024

Conversation

canavarrete01
Copy link
Contributor

Short description: Ingest of 2MASS 0415-09. Updates the Burg03 IRTF data within the JSON file, adds the AKARI (Sora12), FIRE (Simc13), KECK I LRIS (Burg04), and KECK I LRIS (Kirk08) data using a new script.

Link to relevant issue: Closes #559 & #375

For data ingests:
[x] includes script used for ingest
[x ] includes modified JSON files
[ ] Add new tests
[ ] Update the Versions table

@canavarrete01 canavarrete01 requested a review from kelle November 13, 2024 18:50
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good code but too automated for this particular use case. For this situation, do each ingestion one-by-one.

data/reference/Instruments.json Outdated Show resolved Hide resolved
scripts/ingests/Ingest_2MASS_J0415_09.py Outdated Show resolved Hide resolved
scripts/ingests/Ingest_2MASS_J0415_09.py Outdated Show resolved Hide resolved
data/reference/Publications.json Outdated Show resolved Hide resolved
data/reference/Telescopes.json Outdated Show resolved Hide resolved
scripts/ingests/Ingest_2MASS_J0415_09.py Outdated Show resolved Hide resolved
"regime": "nir",
"telescope": "AKARI",
"instrument": "IRC",
"mode": "NIR",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through the paper and I found that this observation was taken in mode "IRC04".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mode should be IRC04, not NIR

data/reference/Instruments.json Outdated Show resolved Hide resolved
@canavarrete01
Copy link
Contributor Author

Submitted new edits to the ingest script. Updated JSON files as well to include necessary references for AKARI.

@canavarrete01
Copy link
Contributor Author

All test pass now! Updated the following lines in test_data.py to update the number of spectra to be found in the database.

def test_spectra(db):
    regime = "nir"
    t = db.query(db.Spectra).filter(db.Spectra.c.regime == regime).astropy()
    **assert len(t) == 582, f"found {len(t)} spectra in the {regime} regime"**

Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! Just a few data fixes.

data/reference/Telescopes.json Outdated Show resolved Hide resolved
data/reference/Instruments.json Outdated Show resolved Hide resolved
data/reference/Instruments.json Outdated Show resolved Hide resolved
scripts/ingests/Ingest_2MASS_J0415_09.py Outdated Show resolved Hide resolved
scripts/ingests/Ingest_2MASS_J0415_09.py Outdated Show resolved Hide resolved
tests/test_data.py Outdated Show resolved Hide resolved
@canavarrete01
Copy link
Contributor Author

canavarrete01 commented Nov 19, 2024

Ingested the publication for the IRC instrument. Added details to the AKARI telescope entry. Corrected the regime values for the LRIS KECK spectra to optical from nir. Adjusted test_data.py file to reflect these changes so all tests pass.

Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll update the Versions table and make a new release.

@kelle kelle merged commit 4306792 into SIMPLE-AstroDB:main Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest new JWST data and derived parameters from Alej24/25 for 0415-90
2 participants