Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SMB and VNC to port scanner #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,27 @@ An example output may look like this:
"score" : 100,
"scoreType" : "success",
"testDetails" : null
}, {
"name" : "SMB",
"hasError" : false,
"errorMessage" : null,
"score" : 100,
"scoreType" : "success",
"testDetails" : null
}, {
"name" : "TELNET",
"hasError" : false,
"errorMessage" : null,
"score" : 100,
"scoreType" : "hidden",
"testDetails" : null
}, {
"name" : "VNC",
"hasError" : false,
"errorMessage" : null,
"score" : 100,
"scoreType" : "hidden",
"testDetails" : null
}]
}
```
Expand All @@ -96,4 +110,6 @@ An example output may look like this:
| RDP | Checks if the port for RDP is open |
| MSSQL | Checks if the port for MS-SQL is open |
| MYSQL | Checks if the port for MY-SQL is open |
| SMB | Checks if the port for SMB is open |
| VNC | Checks if the port for VNC is open |

12 changes: 12 additions & 0 deletions src/main/java/de/rub/nds/siwecos/port/PortScannerCallback.java
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ public ScanResult reportToScanResult(PortScannerReport report) {
resultList.add(getMySqlIsOpen(report));
resultList.add(getRdpIsOpen(report));
resultList.add(getTelnetIsOpen(report));
resultList.add(getVncIsOpen(report));
resultList.add(getSmbIsOpen(report));

int max = 100;
boolean hasError = false;
Expand Down Expand Up @@ -195,4 +197,14 @@ private TestResult getIrcIsOpen(PortScannerReport report) {
return new TestResult("IRC", report.getIrcIsOpen() == null, null, report.getIrcIsOpen() == Boolean.TRUE ? 0
: 100, !(report.getIrcIsOpen() == Boolean.TRUE) ? "success" : "warning", null);
}

private TestResult getVncIsOpen(PortScannerReport report) {
return new TestResult("VNC", report.getVncIsOpen() == null, null, report.getVncIsOpen() == Boolean.TRUE ? 0
: 100, !(report.getVncIsOpen() == Boolean.TRUE) ? "success" : "warning", null);
}

private TestResult getSmbIsOpen(PortScannerReport report) {
return new TestResult("SMB", report.getSmbIsOpen() == null, null, report.getSmbIsOpen() == Boolean.TRUE ? 0
: 100, !(report.getSmbIsOpen() == Boolean.TRUE) ? "success" : "warning", null);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ private void adjustReport(PortScannerReport portScannerReport) {
case 194:
portScannerReport.setIrcIsOpen(true);
break;
case 445:
portScannerReport.setSmbIsOpen(true);
break;
case 1433:
portScannerReport.setMsSqlIsOpen(true);
break;
Expand All @@ -141,6 +144,10 @@ private void adjustReport(PortScannerReport portScannerReport) {
case 3389:
portScannerReport.setRdpIsOpen(true);
break;
case 5800:
case 5900:
portScannerReport.setVncIsOpen(true);
break;
case 80: // HTTP
case 443: // HTTPS
case 22: // SSH
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ public class PortScannerReport {
private Boolean rdpIsOpen = false;
private Boolean msSqlIsOpen = false;
private Boolean ircIsOpen = false;
private Boolean vncIsOpen = false;
private Boolean smbIsOpen = false;

private List<PortResult> questionableResultList;

Expand Down Expand Up @@ -114,4 +116,21 @@ public Boolean getIrcIsOpen() {
public void setIrcIsOpen(Boolean ircIsOpen) {
this.ircIsOpen = ircIsOpen;
}

public Boolean getVncIsOpen() {
return VncIsOpen;
}

public void setVncIsOpen(Boolean VncIsOpen) {
this.VncIsOpen = VncIsOpen;
}

public Boolean getSmbIsOpen() {
return SmbIsOpen;
}

public void setSmbIsOpen(Boolean SmbIsOpen) {
this.SmbIsOpen = SmbIsOpen;
}

}