Add message presenter, updated .pre-commit-config.yaml - EMAIL UPDATE 1/2 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I added max TLP and link prefix so it can be used in templates when multiple report items are selected. |
|
Just included recommendations field for link prefix addition. |
|
Fixed issues that caused MISP generation failure. |
multiflexi
changed the title
|
Simplified templates. |
|
I think it is finished. Please review. |
|
Added user data without password to product for presenters. |
milankowww
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As name suggests, message presenter outputs title and message body from templates. It outputs message_title and message_body. Email publisher in the second pull request either uses this or works similarly to the current state.
This commit also updates pre-commit configuration:
newer black version
added flake8
newer pre-commit-hooks version
added verification of yaml syntax and check if end of file ends with only newline
Feel free to suggest improvements.