Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MISP template #159

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix MISP template #159

merged 1 commit into from
Sep 27, 2023

Conversation

multiflexi
Copy link
Contributor

This way it is closer to the specification.
Added "Event" at the beginning. Added UUID to event.

BUT

  • There is still not an UUID for Attribute, that is mandatory according to specs.
  • Generates MISP only for the first report item. I think each report must to be generated to separate file. But this way it is at least valid JSON (although with duplicate key), that is possible to open without issues.

@multiflexi
Fix MISP template
017e8ad 
This way it is closer to the specification.
milankowww
milankowww approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@milankowww milankowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@milankowww milankowww merged commit 61d1fd2 into SK-CERT:main Sep 27, 2023
2 checks passed
@multiflexi multiflexi deleted the patch-1 branch February 8, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milankowww milankowww milankowww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@multiflexi @milankowww