Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVSS might be inserted as a number #163

Closed
wants to merge 1 commit into from
Closed

Conversation

multiflexi
Copy link
Contributor

@multiflexi multiflexi commented Sep 11, 2023

This adds very simple option to insert and store CVSS as a number.

This is not the best solution and it should be improved:

  1. When CVSS is inserted, colored boxes showing three scores should display it too as in case when vector is inserted.
  2. Calculator button should work when a number is inserted instead of vector.
  3. Values and vector should be inserted and stored separately - but the input should be maybe mutually exclusive. This would enable the use of both vector and values in presenter.
  4. Because of introduction of CVSS 4.0, new calculator (and string parsing) is necessary too.

@milankowww
Copy link
Collaborator

You are very correct in your assessment that values and vector should be inserted and stored separately. This has been planned for a long time, and we will have to do it soon. For the time being, I'm leaving this PR open.

@milankowww
Copy link
Collaborator

I have pulled the text from our internal specs into issue #165.

Progress1 pushed a commit to Progress1/Taranis-NG that referenced this pull request Jan 23, 2024
Same as  SK-CERT#163 CVSS might be inserted as a number (small improvements, fixed default value, 1 decimal point, some code enhacements)
Progress1 pushed a commit to Progress1/Taranis-NG that referenced this pull request Feb 2, 2024
Same as  SK-CERT#163 CVSS might be inserted as a number (small improvements, fixed default value, 1 decimal point, some code enhacements)
@Progress1
Copy link
Collaborator

I enhance little bit this request in #203 Allow store CVSS as number, so i close this (same changes + some additional fixes)

@Progress1 Progress1 closed this Mar 7, 2024
Progress1 added a commit that referenced this pull request Mar 7, 2024
Allow store CVSS as number (quick need for reporting, #163 replacement)
@multiflexi multiflexi deleted the cvss branch July 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants