Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pixel data is valid when validation is skipped #430

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

rkm
Copy link
Member

@rkm rkm commented Jan 8, 2024

This is a follow-up to #429.

While we now skip validation of pixel data for selected image types, we still want to ensure that the pixel data elements are valid when opened via DicomImage. This change first checks the SOPClassUID.IsImageStorage value to ensure we only look for pixel data in files which should contain images, and not e.g., SRs.

@rkm rkm changed the title ensure pixel data is valid when validation is skipped Ensure pixel data is valid when validation is skipped Jan 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ce9bd2) 39.31% compared to head (f1509ae) 39.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   39.31%   39.57%   +0.25%     
==========================================
  Files          67       67              
  Lines        3828     3841      +13     
  Branches      514      515       +1     
==========================================
+ Hits         1505     1520      +15     
  Misses       2227     2227              
+ Partials       96       94       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkm rkm force-pushed the fix/missing-pixel-data branch from bb05d98 to 98e41f7 Compare January 8, 2024 13:59
@rkm rkm merged commit 3ca465c into main Jan 8, 2024
5 checks passed
@rkm rkm deleted the fix/missing-pixel-data branch January 8, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants